[Bug 744339] Review Request: dieharder - Random number generator tester and timer

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744339

Thomas Spura <tomspur at fedoraproject.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |tomspur at fedoraproject.org

--- Comment #1 from Thomas Spura <tomspur at fedoraproject.org> 2011-10-09 09:09:30 EDT ---
Just a few comments for now:
- Why is the prober source0 commented out?
  Did you change the source somehow, so it's not this anymore?:
  http://www.phy.duke.edu/~rgb/General/dieharder/dieharder-%{version}.tgz

- Why do you:
  autoreconf
  ./autogen.sh
  ?

  ./configure works directly without that and you apply no patches.

- The description looks odd, could you delete the passages with "I have" and
such thinks?

- Did you notify upstream of "incorrect-fsf-address" in some files?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.