[Bug 744339] Review Request: dieharder - Random number generator tester and timer

bugzilla at redhat.com bugzilla at redhat.com
Sun Oct 9 22:05:48 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744339

--- Comment #4 from Jiri Hladky <hladky.jiri at gmail.com> 2011-10-09 18:05:47 EDT ---
Hi Ralf,

(In reply to comment #2)
> Some further remarks:
> 
> - The package builds using -I/usr/include.
> This is a beginner's mistake, which causes the package to use a broken include
> path (The origin of this is a bug inside of the configure script)

I can see what you mean. How can I fix it? 

$grep usr/incl configure
oldincludedir='/usr/include'
  --oldincludedir=DIR     C header files for non-gcc [/usr/include]

Could please give me an advice how to deal with it? 

> 
> - The warnings GCC issues, indicates this package isn't 64 bit clean
> (Most of the spots GCC warns about are pretty simple to fix).

I have compared 32bit and 64 bit builds. It seems that in 64 bit builds
following type of the warning will appear (not in i686 builds):

bits.c: In function 'get_int_bit':
bits.c:327:4: warning: format '%lu' expects argument of type 'long unsigned
int', but argument 4 has type 'unsigned int' [-Wformat]

Is it what you mean?

Thanks
Jirka

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list