[Bug 588428] Review Request: rubygem-addressable - Improved URI/URL handling

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=588428

Vít Ondruch <vondruch at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vondruch at redhat.com

--- Comment #6 from Vít Ondruch <vondruch at redhat.com> 2011-10-10 03:46:48 EDT ---
Also few nits from my side:

* Please replace "Requires: rubygems" with virtual provider "Requires:
ruby(rubygems)". The same apply also for BuildRequires.

* It seems that the pushd on line 54 is useless.

* pushd should be paired with popd in %check section

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.