[Bug 744224] Review Request: perl-XML-SAX-Base - Base class SAX Drivers and Filters

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744224

Marcela Mašláňová <mmaslano at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|needinfo?(mmaslano at redhat.c |
                   |om)                         |

--- Comment #4 from Marcela Mašláňová <mmaslano at redhat.com> 2011-10-10 07:48:34 EDT ---
(In reply to comment #1)
> perl-XML-SAX-Base.src: I: checking-url
> http://search.cpan.org/dist/XML-SAX-Base/ (timeout 10 seconds)
> perl-XML-SAX-Base.src: I: checking-url
> http://www.cpan.org/authors/id/G/GR/GRANTM/XML-SAX-Base-1.08.tar.gz (timeout 10
> seconds)
> perl-XML-SAX-Base.noarch: I: checking
> perl-XML-SAX-Base.noarch: W: spelling-error %description -l en_US behaviour ->
> behavior
> The value of this tag appears to be misspelled. Please double-check.
I did not misspell source tar ball. Specfile for Perl packages is automatically
generated by cpanspec. There are some issues, but I was able download it by
wget.

> 
> perl-XML-SAX-Base.noarch: I: checking-url
> http://search.cpan.org/dist/XML-SAX-Base/ (timeout 10 seconds)
> perl-XML-SAX-Base.noarch: E: non-executable-script
> /usr/share/perl5/vendor_perl/XML/SAX/BuildSAXBase.pl 0644L /usr/bin/perl
> This text file contains a shebang or is located in a path dedicated for
> executables, but lacks the executable bits and cannot thus be executed.  If
> the file is meant to be an executable script, add the executable bits,
> otherwise remove the shebang or move the file elsewhere.
> 
> perl-XML-SAX-Base.spec: I: checking-url
> http://www.cpan.org/authors/id/G/GR/GRANTM/XML-SAX-Base-1.08.tar.gz (timeout 10
> seconds)
> 2 packages and 1 specfiles checked; 1 errors, 2 warnings.
> 
> The spelling errors are eventually ignorable, however, "behaviour" is the
> British spelling and should be changed to "behavior".
> 
I won't change upstream description written by native speaker.

> More important is the file
> /usr/share/perl5/vendor_perl/XML/SAX/BuildSAXBase.pl. It is probably not
> intended to leave it as unexecutable...? Usually, a Perl module doesn't include
> a shebang.

I thought about moving it into docs, but that's not right installation path.
I'd rather leave it where it is. It's mentioned in Base.pm and someone might
need it. Not sure about this one.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.