[Bug 737401] Review Request: saga - Geographic information system with an API for processing geodata

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737401

--- Comment #5 from Jerry James <loganjerry at gmail.com> 2011-10-10 20:52:33 EDT ---
Great.  I pulled his new build of g2clib from koji and did the two fixes I
requested by hand for this review.

+: OK
-: must be fixed
=: should be fixed (at your discretion)
N: not applicable

MUST:
[=] rpmlint output:
saga.x86_64: W: spelling-error Summary(en_US) geodata -> gestate
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_richtext-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_aui-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_xrc-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_qa-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_html-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_gtk2u_adv-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_baseu_xml-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libwx_baseu_net-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_gdi-2.0.7.so
/usr/lib64/libhpdf-2.1.0.so
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_richtext-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_aui-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_xrc-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_qa-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_html-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_gtk2u_adv-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libwx_baseu_net-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api-2.0.7.so
/usr/lib64/libhpdf-2.1.0.so
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_richtext-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_aui-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_xrc-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_qa-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_html-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_adv-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_gtk2u_core-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_baseu_xml-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_baseu_net-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libwx_baseu-2.8.so.0
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/usr/lib64/libhpdf-2.1.0.so
saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_odbc-2.0.7.so
/lib64/libm.so.6
saga-python.x86_64: W: no-documentation
saga-devel.x86_64: W: no-documentation
saga.spec:9: W: macro-in-comment %{name}
saga.spec:9: W: macro-in-comment %{name}
saga.spec:9: W: macro-in-comment %{version}
saga.spec: W: invalid-url Source0: saga_2.0.7-fedora.tar.gz
3 packages and 1 specfiles checked; 0 errors, 36 warnings.

The spelling warning is bogus.  Can you do anything about this unused direct
shared library dependencies?  They should be dropped from the respective
library link commands, if possible.  Also, please fix the 3 macro-in-comment
warnings in the spec file by doubling the % characters on that line.

[+] follows package naming guidelines
[+] spec file base name matches package name
[+] package meets the packaging guidelines
[+] package uses a Fedora approved license
[-] license field matches the actual license: licensecheck shows the following:
    there are some MIT-licensed files in
src/modules_io/esri_e00/io_esri_e00/e00compr;
    some files are GPLv2, not GPLv2+, such as
src/modules_projection/pj_proj4/pj_proj4/crs_base.h;
    there is a BSD-licensed file: src/saga_core/saga_odbc/otlv4.h; and
    there are wxWindows licensed files in src/saga_core/saga_gui/wx/propgrid.
[+] license file is included in %doc
[+] spec file is in American English
[+] spec file is legible
[+] sources match upstream: no, but that is intentional, since non-free sources
had to be removed.  The sources otherwise match, according to diff.
[+] package builds on at least one primary arch (tried x86_64)
[N] appropriate use of ExcludeArch
[+] all build requirements in BuildRequires
[N] spec file handles locales properly
[+] ldconfig in %post and %postun
[-] no bundled copies of system libraries: there are some.  This should not be
considered an exhaustive list:
    E00compr library (http://avce00.maptools.org/e00compr/e00compr.html) is in
src/modules_io/esri_e00/io_esri_e00/e00compr;
    dxflib (http://www.ribbonsoft.com/dxflib.html) is in
src/modules_io/shapes/io_shapes_dxf/dxflib;
    otl (http://otl.sourceforge.net/) is in src/saga_core/saga_odbc;
    wxPropertyGrid (http://wxpropgrid.sourceforge.net/) is in
src/saga_core/saga_gui/wx/propgrid
[N] no relocatable packages
[-] package owns all directories that it creates: %{_includedir}/saga is not
owned by any package
[+] no files listed twice in %files
[+] proper permissions on files
[+] consistent use of macros
[+] code or permissible content
[N] large documentation in -doc
[+] no runtime dependencies in %doc
[+] header files in -devel
[N] static libraries in -static
[+] .so in -devel
[+] -devel requires main package
[+] package contains no libtool archives
[+] package contains a desktop file, uses desktop-file-install
[+] package does not own files/dirs owned by other packages
[+] all filenames in UTF-8

SHOULD:
[N] query upstream for license text
[N] description and summary contains available translations
[+] package builds in mock: tried fedora-rawhide-i386
[+] package builds on all supported arches: tried i386 and x86_64
[+] package functions as described: minimal testing only
[+] sane scriptlets
[+] subpackages require the main package
[N] placement of pkgconfig files
[N] file dependencies versus package dependencies
[+] package contains man pages for binaries/scripts

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.