[Bug 741900] Review Request: grinder - A tool for synchronizing repositories and their contents

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 11 10:18:51 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=741900

Volker Fröhlich <volker27 at gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |volker27 at gmx.at

--- Comment #2 from Volker Fröhlich <volker27 at gmx.at> 2011-10-11 06:18:50 EDT ---
The license file is in the source package twice. One copy is included, that's
fine.

Does the unit test work?

You can leave out the "-n grinder-%{version}", because that is exactly what the
setup macro expects.

If you're not going for EPEL 4, you can remove defattr.

You should probably only define python_sitelib on systems that don't define it:

http://fedoraproject.org/wiki/Packaging:Python#Macros

It seems to me, python-hashlib is part of the Python package, at least from 2.5
on.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list