[Bug 744492] Review Request: rtmidi - Library for realtime MIDI input/output

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744492

Tom "spot" Callaway <tcallawa at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |tcallawa at redhat.com
         AssignedTo|nobody at fedoraproject.org    |tcallawa at redhat.com
               Flag|                            |fedora-review+

--- Comment #1 from Tom "spot" Callaway <tcallawa at redhat.com> 2011-10-11 10:39:44 EDT ---
== REVIEW ==
rpmlint output:
rtmidi.src: W: spelling-error Summary(en_US) realtime -> mealtime, real time,
real-time
rtmidi.src: W: spelling-error %description -l en_US realtime -> mealtime, real
time, real-time
rtmidi.x86_64: W: spelling-error Summary(en_US) realtime -> mealtime, real
time, real-time
rtmidi.x86_64: W: spelling-error %description -l en_US realtime -> mealtime,
real time, real-time
rtmidi-jack.x86_64: W: spelling-error Summary(en_US) realtime -> mealtime, real
time, real-time
rtmidi-jack.x86_64: W: spelling-error %description -l en_US realtime ->
mealtime, real time, real-time

All safe to ignore.

- package meets naming guidelines
- package meets packaging guidelines
- license (MIT) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
(b1aaa6ff72e1385a7a29b4a2ab60c49863663bdf8c55bac93d548aacc8b6bc56)
- package compiles on f16 (x86_64)
- no missing BR
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
- devel package ok
- no .la files
- post/postun ldconfig ok
- devel requires base packages n-v-r 

APPROVED. Nice work with the patching, hopefully upstream will take it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.