[Bug 743162] Review Request: python-concurrentloghandler - Concurrent logging handler

bugzilla at redhat.com bugzilla at redhat.com
Tue Oct 11 16:46:35 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=743162

Pierre-YvesChibon <pingou at pingoured.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |pingou at pingoured.fr

--- Comment #1 from Pierre-YvesChibon <pingou at pingoured.fr> 2011-10-11 12:46:34 EDT ---
I believe you should use %global instead of %define.

Otherwise, do you plan to have this on epel ?
If not, you can do some cleaning:
http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
http://fedoraproject.org/wiki/Packaging/Guidelines#File_Permissions
http://fedoraproject.org/wiki/Packaging:Python#Macros

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list