[Bug 745218] Review Request: rpc2 - C library for remote procedure calls over UDP

Tue Oct 11 18:01:49 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=745218

Pierre-YvesChibon <pingou at pingoured.fr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
               Flag|                            |fedora-review+

--- Comment #1 from Pierre-YvesChibon <pingou at pingoured.fr> 2011-10-11 14:01:49 EDT ---

Package Review
==============

Key:
- = N/A
x = Check
! = Problem
? = Not evaluated

[x] : MUST - Fully versioned dependency in subpackages, if present.
[x] : MUST - Spec file lacks Packager, Vendor, PreReq tags.
[x] : MUST - Package use %makeinstall only when make install DESTDIR=...
doesn't work.
[x] : MUST - Package is named according to the Package Naming Guidelines.
[!] : MUST - Rpmlint output is silent.
rpc2-devel.x86_64: W: no-manual-page-for-binary rp2gen
rpc2.x86_64: W: shared-lib-calls-exit /usr/lib64/librpc2.so.5.4.5
exit at GLIBC_2.2.5
rpc2.x86_64: W: shared-lib-calls-exit /usr/lib64/libse.so.5.4.5
exit at GLIBC_2.2.5
(none): E: no installed packages by name Wrote:
4 packages and 0 specfiles checked; 0 errors, 4 warnings.

[x] : MUST - Sources used to build the package matches the upstream source, as
provided in the spec URL.
        /home/pierrey/tmp/reviewhelper/745218/rpc2-2.10.tar.gz :
          MD5SUM this package     : 545066e67d95325840a79d163098096b
          MD5SUM upstream package : 545066e67d95325840a79d163098096b

[x] : MUST - Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[-] : MUST - %config files are marked noreplace or the reason is justified.
[-] : MUST - Package contains a properly installed %{name}.desktop using
desktop-file-install file if it is a GUI application.
[-] : MUST - The spec file handles locales properly.
[-] : MUST - No %config files under /usr.
[x] : MUST - Header files in -devel subpackage, if present.
[x] : MUST - ldconfig called in %post and %postun if required.
[x] : MUST - Package does not contain any libtool archives (.la)
[x] : MUST - Package does not contains kernel modules.
[x] : MUST - Package contains no static executables.
[x] : MUST - Rpath absent or only used for internal libs.
[x] : MUST - Package is not relocatable.
[x] : MUST - Development .so files in -devel subpackage, if present.
[-] : MUST - Static libraries in -static subpackage, if present.
[x] : MUST - Package has adequate build section.
[x] : MUST - Package contains the mandatory BuildRequires.
[x] : MUST - Package successfully compiles and builds into binary rpms on at
least one supported architecture.
[x] : MUST - Package is licensed with an open-source compatible license and
meets other legal requirements as defined in the legal section of Packaging
Guidelines.
[x] : MUST - %build honors applicable compiler flags or justifies otherwise.
[x] : MUST - All build dependencies are listed in BuildRequires, except for any
that are listed in the exceptions section of Packaging Guidelines.
[x] : MUST - Package contains no bundled libraries.
[x] : MUST - Changelog in prescribed format.
[x] : MUST - Sources contain only permissible code or content.
[x] : MUST - Macros in Summary, %description expandable at SRPM build time.
[x] : MUST - Package requires other packages for directories it uses.
[x] : MUST - Package uses nothing in %doc for runtime.
[x] : MUST - Package is not known to require ExcludeArch.
[x] : MUST - Permissions on files are set properly.
[x] : MUST - Package does not contain duplicates in %files.
[-] : MUST - Large documentation files are in a -doc subpackage, if required.
[x] : MUST - If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %doc.
[x] : MUST - License field in the package spec file matches the actual license.
[x] : MUST - License file installed when any subpackage combination is
installed.
[x] : MUST - Package consistently uses macros. instead of hard-coded directory
names.
[x] : MUST - Package meets the Packaging Guidelines.
[x] : MUST - Package does not generates any conflict.
[x] : MUST - Package obeys FHS, except libexecdir and /usr/target.
[x] : MUST - Package must own all directories that it creates.
[x] : MUST - Package does not own files or directories owned by other packages.
[x] : MUST - Package installs properly.
[x] : MUST - Requires correct, justified where necessary.
[x] : MUST - Spec file is legible and written in American English.
[-] : MUST - Package contains a SysV-style init script if in need of one.
[x] : MUST - File names are valid UTF-8.
[x] : MUST - Useful -debuginfo package or justification otherwise.
[x] : SHOULD - Dist tag is present.
[x] : SHOULD - SourceX / PatchY prefixed with %{name}.
[x] : SHOULD - SourceX is a working URL.
[x] : SHOULD - Spec use %global instead of %define.
[-] : SHOULD - If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it.
[x] : SHOULD - No file requires outside of /etc, /bin, /sbin, /usr/bin,
/usr/sbin.
[x] : SHOULD - Final provides and requires are sane (rpm -q --provides and rpm
-q --requires).
[x] : SHOULD - Package functions as described.
[x] : SHOULD - Latest version is packaged.
[x] : SHOULD - Package does not include license text files separate from
upstream.
[!] : SHOULD - Man pages included for all executables.
[-] : SHOULD - Patches link to upstream bugs/comments/lists or are otherwise
justified.
[-] : SHOULD - Scriptlets must be sane, if used.
[-] : SHOULD - Description and summary sections in the package spec file
contains translations for supported Non-English languages, if available.
[-] : SHOULD - Package should compile and build into binary rpms on all
supported architectures.
[-] : SHOULD - %check is present and all tests pass.
[x] : SHOULD - Packages should try to preserve timestamps of original installed
files.

This package is APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.