[Bug 745123] Review request: cryptsetup

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=745123

--- Comment #2 from Milan Broz <mbroz at redhat.com> 2011-10-12 07:09:30 EDT ---
(In reply to comment #1)
> Release: 0.1 is unusual, but you are upstream, so probably aware of it.

0.1 means rc1, 1.4.0-1 will be stable release (logic stolen from util-linux:-),
this ensures that first stable release will override release candidates.

> Rpmlint:
> rpmlint lies, I can download your source tarball. The fsf address should be
> changed according to guidelines. You should create ticket for upstream (you)
> and fix it in some future release of upstream package.

NACK. this is nonsense, sorry.

> These lines are not needed since F-14, but they are still needed in RHEL-5 and
> older:
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) 
> clean section
> %defattr(-,root,root,-)
> rm -rf $RPM_BUILD_ROOT in install section

ok, I'll remove them.


Thanks!

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.