[Bug 745547] Review Request: svn2cl - Create a ChangeLog from a Subversion log

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=745547

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |jussi.lehtola at iki.fi
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi
               Flag|                            |fedora-review+

--- Comment #2 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-10-12 17:59:46 EDT ---
rpmlint output:
svn2cl.noarch: E: explicit-lib-dependency libxslt
svn2cl.noarch: W: obsolete-not-provided subversion-svn2cl
2 packages and 0 specfiles checked; 1 errors, 1 warnings.

I think you should Provides: subversion-svn2cl for now.


MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
$ md5sum svn2cl-0.13.tar.gz ../SOURCES/svn2cl-0.13.tar.gz 
39764d18ef342145863d5d4e21610e2d  svn2cl-0.13.tar.gz
39764d18ef342145863d5d4e21610e2d  ../SOURCES/svn2cl-0.13.tar.gz

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. N/A
MUST: Permissions on files must be set properly. OK
MUST: Large documentation files must go in a -doc subpackage. N/A

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. ??
- I don't think the style sheet svn2html.css belongs in -doc.

MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned, architecture dependent dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK


Please add the provide and remove the stylesheet from -doc (if it indeed isn't
necessary) before git import. The package has been

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.