[Bug 744944] Review Request: humanity-icon-theme - Humanity icon theme

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=744944

Mario Blättermann <mariobl at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at freenet.de

--- Comment #4 from Mario Blättermann <mariobl at freenet.de> 2011-10-13 15:13:47 EDT ---
Koji scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3429303

$ rpmlint -i -v *
humanity-icon-theme.src: I: checking
humanity-icon-theme.src: I: checking-url https://launchpad.net/humanity/
(timeout 10 seconds)
humanity-icon-theme.src: W: invalid-url Source0:
humanity-icon-theme-0.5.3.11-without-logos.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.

humanity-icon-theme.noarch: I: checking
humanity-icon-theme.noarch: I: checking-url https://launchpad.net/humanity/
(timeout 10 seconds)
humanity-icon-theme.noarch: E: incorrect-fsf-address
/usr/share/doc/humanity-icon-theme-0.5.3.11/COPYING
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

humanity-icon-theme.spec: W: invalid-url Source0:
humanity-icon-theme-0.5.3.11-without-logos.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.

/home/mariobl/Downloads/Reviews/humanity-icon-theme/humanity-icon-theme-0.5.3.11-2.fc16.src/humanity-icon-theme.spec:
W: invalid-url Source0: humanity-icon-theme-0.5.3.11-without-logos.tar.bz2
The value should be a valid, public HTTP, HTTPS, or FTP URL.

2 packages and 2 specfiles checked; 1 errors, 3 warnings.



Your way to generate the tarball isn't canonical. In my mind, you should use
the original tarball and run your script in %build. This makes it easier to get
the checksum for the tarball.

The incorrect FSF address doesn't need to be fixed, but it is worth an upstream
bug.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.