[Bug 711895] Review Request: softhsm - Software version of a PKCS#11 Hardware Security Module

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711895

--- Comment #3 from Wes Hardaker <wjhns174 at hardakers.net> 2011-10-15 11:21:05 EDT ---
The important ones:

  -devel description:
     Summary: Development package that (does not?) includes header files
     Description: The devel package contains the libsofthsm library and (no?)
include files

     + Pick one? (hint, it does)

  - [ ] MUST: Every binary RPM package (or subpackage) which stores
    shared library files (not just symlinks) in any of the dynamic
    linker's default paths, must call ldconfig in %post and %postun.
    - Needs to be added

  - [ ] MUST: Static libraries must be in a -static package.
    - Err... they're in -devel.  That's a new requirement to me as
      well.  It's certainly not consistently enforced yet.

Also of note is this one (but it's not a blocker, IMHO)

  - [X] MUST: The License field in the package spec file must match
    the actual license.
    - Note: the only copyright statements are in the source code, but
      are BSD licenses.  Work with the upstream to add a top-level file?

I do think having /var/softhsm owned by a softhsm group would be more helpful
for mulit-operator environments.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.