[Bug 736801] Review Request: pure-gen - A Pure C bindings generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736801

Jens Petersen <petersen at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

Bug 736801 depends on bug 530688, which changed state.

Bug 530688 Summary: Review Request: ghc-language-c - Haskell language-c library
https://bugzilla.redhat.com/show_bug.cgi?id=530688

           What    |Old Value                   |New Value
----------------------------------------------------------------------------
         Resolution|                            |ERRATA
             Status|ON_QA                       |CLOSED

--- Comment #6 from Jens Petersen <petersen at redhat.com> 2011-10-15 11:29:38 EDT ---
Sorry for the long wait.



Here is the review:

 +:ok, !: needs attention, NA: not applicable

MUST Items:
[+] MUST: rpmlint output [1]

pure-gen.src: W: invalid-url Source0:
http://pure-lang.googlecode.com/files/pure-gen-0.13.tar.gz HTTP Error 404: Not
Found

I believe this is normal for googlecode.

[+] MUST: package named according to Package Naming Guidelines
[+] MUST: spec file name must match base package %{name} [2]
[+] MUST: meet Packaging Guidelines
[+] MUST: Fedora approved license and Licensing Guidelines
BSD 3 clause
[+] MUST: License field in the package spec file must match actual license. [3]
[+] MUST: include license files in %doc if available in source [4]
[+] MUST: The spec file must be written in American English [5] and be legible.
[6]
[+] MUST: source md5sum matches upstream release (from upstream URL)

19e036fd835afda0580e1fc1c4068723  Downloads/pure-gen-0.13.tar.gz

[+] MUST: successfully compile and build into binary rpms on a primary arch [7]

http://koji.fedoraproject.org/koji/taskinfo?taskID=3433148

[!] MUST: if necessary use ExcludeArch for other archs [8]

You could use "ExclusiveArch: %{ghc_arches}".

[+] MUST: All build dependencies must be listed in BuildRequires
[NA] MUST: use %find_lang macro for .po translations [9]
[NA] MUST: packages which store shared library files in the dynamic linker's
default paths, must call ldconfig in %post and %postun. [10]
[+] MUST: Packages must NOT bundle copies of system libraries. [11]
[NA] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review [12]
[+] MUST: A package must own all directories that it creates. [13]
[+] MUST: A package must not contain any duplicate files in the %files listing.
[14]
[+] MUST: Permissions on files must be set properly. [15]
[+] MUST: consistently use macros [16]
[+] MUST: The package must contain code, or permissable content. [17]
[NA] MUST: Large documentation files should go in a doc subpackage. [18]
[+] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. [18]
[NA] MUST: Header files must be in a -devel package. [19]
[NA] MUST: Static libraries must be in a -static package. [20]
[NA] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package. [19]
[NA] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency [21]
[NA] MUST: Packages must NOT contain any .la libtool archives, these should be
removed in the spec. [20]
[NA] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. [22]
[+] MUST: Packages must not own files or directories already owned by other
packages. [23]
[+] MUST: All filenames in rpm packages must be valid UTF-8. [24]

SHOULD Items:
[+] SHOULD: If scriptlets are used, those scriptlets must be sane. [29]
[+] SHOULD: your package should contain man pages for binaries/scripts.


Package is APPROVED.


Some suggestions:

- You could patch the makefile to use ghc -dynamic linking for dump-ast
  on primary archs, to save a lot of space and some time too.
- Better to remove the commented out lines on the .spec file.
- "rm -rf $RPM_BUILD_ROOT" is deprecated and can be removed (except for
EPEL-5).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.