[Bug 745510] Review Request: vdsm - Virtual Desktop Server Manager

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=745510

--- Comment #4 from Douglas Schilling Landgraf <dougsland at redhat.com> 2011-10-15 17:21:51 EDT ---
Hello Federico,

      You should raise the flag fedora-review to get attention from reviewers
(I have added now), next time please use it. I have reviewed the spec/package,
please check the items marked as WARN (not blocker), blocker items for package
approval are marked as FAIL.

Thanks
Douglas

From: http://fedoraproject.org/wiki/Packaging:ReviewGuidelines

[OK] MUST: rpmlint must be run on the source rpm and all binary rpms the build
produces. The output should be posted in the review

$ rpmlint vdsm.spec 
vdsm.spec: W: invalid-url Source0: vdsm-%{version}.tar.gz
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$ rpmlint vdsm-4.9.0-0.192.g69eb727.fc15.src.rpm 
vdsm.src: W: invalid-url Source0: vdsm-%{version}.tar.gz
1 packages and 0 specfiles checked; 0 errors, 1 warnings

[OK] MUST: The package must be named according to the Package Naming Guidelines
.

[OK] MUST: The spec file name must match the base package %{name}, in the
format %{name}.spec unless your package has an exemption.

[OK] MUST: The package must meet the Packaging Guidelines .

[OK] MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .

[OK] MUST: The License field in the package spec file must match the actual
license. 

[OK] MUST: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package must be included in %doc

[OK] MUST: The spec file must be written in American English.

[OK] MUST: The spec file for the package MUST be legible.

[FAIL] MUST: The sources used to build the package must match the upstream
source, as provided in the spec URL. Reviewers should use md5sum for this task.
If no upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.

From: http://fedoraproject.org/wiki/Packaging/SourceURL

Please include a comment into the SPEC how the .tar.gz was build.
I was not able to locate any reference (commit #, tag, branch) to "g69eb727"
within the pointed upstream git tree --
http://git.fedorahosted.org/git/?p=vdsm.git

[OK] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.

$ mock -r fedora-16-x86_64 vdsm-4.9.0-0.192.g69eb727.fc15.src.rpm

INFO: Done(vdsm-4.9.0-0.192.g69eb727.fc15.src.rpm) Config(fedora-16-x86_64) 1
minutes 3 seconds
INFO: Results and/or logs in: /var/lib/mock/fedora-16-x86_64/result
State Changed: end

$ cat /var/lib/mock/fedora-16-x86_64/result/build.log
<snip>
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/builddir/build/BUILDROOT/vdsm-4.9.0-0.192.g69eb727.fc16.x86_64
Wrote: /builddir/build/RPMS/vdsm-4.9.0-0.192.g69eb727.fc16.x86_64.rpm
Wrote: /builddir/build/RPMS/vdsm-debuginfo-4.9.0-0.192.g69eb727.fc16.x86_64.rpm
Wrote:
/builddir/build/RPMS/vdsm-hook-vhostmd-4.9.0-0.192.g69eb727.fc16.x86_64.rpm
Wrote:
/builddir/build/RPMS/vdsm-debug-plugin-4.9.0-0.192.g69eb727.fc16.x86_64.rpm
Wrote: /builddir/build/RPMS/vdsm-cli-4.9.0-0.192.g69eb727.fc16.x86_64.rpm
Wrote: /builddir/build/RPMS/vdsm-bootstrap-4.9.0-0.192.g69eb727.fc16.x86_64.rpm
Wrote: /builddir/build/RPMS/vdsm-reg-4.9.0-0.192.g69eb727.fc16.x86_64.rpm
Wrote:
/builddir/build/RPMS/vdsm-hook-faqemu-4.9.0-0.192.g69eb727.fc16.x86_64.rpm
Executing(%clean): /bin/sh -e /var/tmp/rpm-tmp.5wZE89
+ umask 022
+ cd /builddir/build/BUILD
+ cd vdsm-4.9.0
+ /bin/rm -rf /builddir/build/BUILDROOT/vdsm-4.9.0-0.192.g69eb727.fc16.x86_64
+ exit 0
Child returncode was: 0
LEAVE do --> 

[N/A] MUST: If the package does not successfully compile, build or work on an
architecture, then those architectures should be listed in the spec in
ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in
bugzilla, describing the reason that the package does not compile/build/work on
that architecture. The bug number MUST be placed in a comment, next to the
corresponding ExcludeArch line. [8]

[WARN] MUST: All build dependencies must be listed in BuildRequires, except for
any that are listed in the exceptions section of the Packaging Guidelines ;
inclusion of those as BuildRequires is optional. Apply common sense.

As clean up suggestion only, you can remove redhat-rpm-config as BuildRequires.

From: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2

Exceptions
There is no need to include the following packages or their dependencies as
BuildRequires because they would occur too often. These packages are considered
the minimum build environment.

<snip>
redhat-rpm-config
</snip>

>From spec:
BuildRequires: python redhat-rpm-config

[N/A] MUST: The spec file MUST handle locales properly. This is done by using
the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

[N/A] MUST: Every binary RPM package (or subpackage) which stores shared
library files (not just symlinks) in any of the dynamic linker's default paths,
must call ldconfig in %post and %postun

[N/A] MUST: Packages must NOT bundle copies of system libraries

[N/A] MUST: If the package is designed to be relocatable, the packager must
state this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker. 

[OK] MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. 

[OK] MUST: A Fedora package must not list a file more than once in the spec
file's %files listings. (Notable exception: license texts in specific
situations)

[OK] MUST: Permissions on files must be set properly. Executables should be set
with executable permissions.

[FAIL] MUST: Each package must consistently use macros

Item 1
=============

>From spec:
%dir %{_localstatedir}/log/core

/etc/init.d/vdsmd   <----- here please replace /etc/init.d to macro 
(%{_initrddir}/vdsmd)

Item 2
===================
As suggestion, I would recommend to use macro vdsm_name to the Name session and
others that call vdsm string directly.

<snip>
%define vdsm_name vdsm

Summary: Virtual Desktop Server Manager
Name: vdsm
Source: %{vdsm_name}-%{version}.tar.gz
</snip>

Item 3
=====================
Please decide if you are going use macros/full path to cp/rm/sed commands or
not. Select one method and use it.

Example:

<snip>
%post
tmp_sudoers=$(mktemp)
cp -a /etc/sudoers $tmp_sudoers  <--- here
</snip>

and 

if outerr=$(/usr/sbin/visudo -c -f $tmp_sudoers 2>&1) ; then
    /bin/cp -a $tmp_sudoers /etc/sudoers  <--- here full path for cp

[OK] MUST: The package must contain code, or permissable content

[N/A] MUST: Large documentation files must go in a -doc subpackage. (The
definition of large is left up to the packager's best judgement, but is not
restricted to size. Large can refer to either size or quantity). 

[OK] MUST: If a package includes something as %doc, it must not affect the
runtime of the application. To summarize: If it is in %doc, the program must
run properly if it is not present.

[N/A] MUST: Header files must be in a -devel package.

[N/A] MUST: Static libraries must be in a -static package.

[N/A] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), then library files that end in .so (without suffix) must go in
a -devel package.

[N/A] MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name}%{?_isa} =
%{version}-%{release}

[N/A] MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.

[N/A] MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the
%install section. If you feel that your packaged GUI application does not need
a .desktop file, you must put a comment in the spec file with your explanation.

[FAIL] MUST: Packages must not own files or directories already owned by other
packages. The rule of thumb here is that the first package to be installed
should own the files or directories that other packages may rely upon. This
means, for example, that no package in Fedora should ever share ownership with
any of the files or directories owned by the filesystem or man package. If you
feel that you have a good reason to own a file or directory that another
package owns, then please present that at package review time. 

<snip> 
%files hook-faqemu
%defattr(-,root,root,-)
%doc COPYING
%{_bindir}/qemu
%{_bindir}/qemu-system-x86_64

qemu and qemu-system-x86_64 are binaries from
qemu-system-x86-0.13.0-1.fc14.x86_64 package which are not owned by vdsm.
Please includes into hook-faqemu session 
"Conflicts: qemu-system-x86"

[OK] MUST: All filenames in rpm packages must be valid UTF-8. 

[OK] SHOULD: If the source package does not include license text(s) as a
separate file from upstream, the packager SHOULD query upstream to include it. 
License text included in COPYING file that comes with upstream tarball

[N/A] SHOULD: The description and summary sections in the package spec file
should contain translations for supported Non-English languages, if available

[OK] SHOULD: The reviewer should test that the package builds in mock. 

[N/A] SHOULD: The package should compile and build into binary rpms on all
supported architectures.

[OK] SHOULD: If scriptlets are used, those scriptlets must be sane. This is
vague, and left up to the reviewers judgement to determine sanity. [

[OK] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.

[N/A] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase,
and this is usually for development purposes, so should be placed in a -devel
pkg. A reasonable exception is that the main pkg itself is a devel tool not
installed in a user runtime, e.g. gcc or gdb. 

[N/A] SHOULD: If the package has file dependencies outside of /etc, /bin,
/sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the
file instead of the file itself. 

[OK] SHOULD: your package should contain man pages for binaries/scripts. If it
doesn't, work with upstream to add them where they make sense.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.