[Bug 713334] Review Request: profdepanne - help desk for user

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=713334

Mario Blättermann <mariobl at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mariobl at freenet.de

--- Comment #1 from Mario Blättermann <mariobl at freenet.de> 2011-10-16 08:02:17 EDT ---
Your spec file has to be written in American English, especially the changelog.
If you want to provide some parts in French, please use the following
additionally:

Summary(fr):        Programme d'aide aux utilisateurs.

%description -l fr
Ce programme permet d'aider les utilisateurs de l'informatique à se dépanner
seul. C'est également un guide de migration vers GNU/Linux qui vous aidera à 
installer et utiliser un système libre.

Use a line wrap at 80 characters for the description to make it better
readable.

The %define on top are not needed. Just write:

Name:           profdepanne 
Version:        2.6 
Release:        1%{?dist}

It's not needed to define a "Prefix:".

If you call desktop-file-utils in BuildRequires, you have also to apply the
appropriate mechanism to install and verify your *.desktop file, see
http://fedoraproject.org/wiki/Packaging:Guidelines#desktop-file-install_usage.

Your package lacks of documentation. As the author of the upstream application,
you should provide at least a README file in *English*. It's annoying for the
users to have all in French. Additionally, you have to provide a license
declaration in your package.

By the way, are you already a packager for Fedora? Or is this your first
package and you need a sponsor?

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.