[Bug 739997] Review Request: undertaker - Find always-on and always-off conditional C code
bugzilla at redhat.com
bugzilla at redhat.com
Mon Oct 17 15:57:44 UTC 2011
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=739997
Jon Ciesla <limb at jcomserv.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |limb at jcomserv.net
AssignedTo|nobody at fedoraproject.org |limb at jcomserv.net
Flag| |fedora-review+
--- Comment #1 from Jon Ciesla <limb at jcomserv.net> 2011-10-17 11:57:44 EDT ---
Good:
- rpmlint checks return:
undertaker.x86_64: W: spelling-error %description -l en_US preprocessor ->
processor, predecessor, compressor
The value of this tag appears to be misspelled. Please double-check.
Ignore.
undertaker.x86_64: W: no-manual-page-for-binary undertaker-calc-coverage
Each executable in standard binary directories should have a man page.
undertaker.x86_64: W: no-manual-page-for-binary zizler
Each executable in standard binary directories should have a man page.
Nice to have, but if they don't publish one. . .
- package meets naming guidelines
- package meets packaging guidelines
- license ( GPLv2 and GPLv3+) OK, text in %doc, matches source
- spec file legible, in am. english
- source matches upstream
- package compiles on devel (x86)
- no missing BR Mock build is good.
- no unnecessary BR
- no locales
- not relocatable
- owns all directories that it creates
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the package-review
mailing list