[Bug 746976] Review Request: python-passlib - Comprehensive password hashing framework supporting over 20 schemes

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=746976

Mark McLoughlin <markmc at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |markmc at redhat.com
               Flag|                            |fedora-review+

--- Comment #4 from Mark McLoughlin <markmc at redhat.com> 2011-10-18 12:00:52 EDT ---
Robert's version looks good to me. rpmlint passes, packaging looks sane.
Licensing is correct. Installs fine and sample code from docs on website works.

I'd like to see these 3 minor things fixed up before or after importing:

 1. Let's do what the comment says:

   # Remove CFLAGS=... for noarch packages (unneeded)

 2. Don't need 'rm -rf %{buildroot}' in %install:

   http://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

 3. Don't need to define %{python_sitelib} anymore:

   http://fedoraproject.org/wiki/Packaging:Python#Macros

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.