[Bug 719908] Review Request: rubygem-multi_json - A gem to provide swappable JSON backends

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719908

--- Comment #4 from Vít Ondruch <vondruch at redhat.com> 2011-10-21 09:42:29 EDT ---
(In reply to comment #3)
> - I'm not sure whether marking %{geminstdir}/Rakefile as %doc is appropriate.
> In my opinion, Rakefile is not documentation (although it is not needed for
> runtime and should stay in the documentation subpackage).

You are right. Fixed.

> - Okjson (the fallback json engine for multi_json) seems to be bundled from
> https://github.com/kr/okjson, but the author of okjson says that his library is
> meant for vendoring. I think that unbundling okjson wouldn't make much sense in
> this case (therefore I don't suggest any change to your specfile, I just think
> it's worth mentioning here) - what is your opinion on this matter? I'd like to
> make this clear before I approve your package.

Sorry, I did not noticed :( This is my opinion: 

https://github.com/kr/okjson/issues/2
https://github.com/intridea/multi_json/issues/30

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.