[Bug 670915] Review Request: aprsg - Amateur Radio APRS Gateway

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=670915

Randall "Randy" Berry <randyn3lrx at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |randyn3lrx at gmail.com

--- Comment #4 from Randall "Randy" Berry <randyn3lrx at gmail.com> 2011-10-22 01:56:07 EDT ---
(In reply to comment #2)
> Some first issues:
> 
> Assuming you want to provide for no older releases than EPEL6 (according to
> libfap), you may drop the BuildRoot definition, the %clean section, "rm -rf
> $RPM_BUILD_ROOT" from %install and %defattr from %files. See
> http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#EL6. For EPEL 6. there
> are currently no differences to the common Fedora packaging guidelines.
> 
> Please remove the gz extension from the manpage in %files and let the build
> system choose the compression format. Well, it is gz now anyway, but could be
> changed in the future.
> 
> Koji scratch build:
> http://koji.fedoraproject.org/koji/taskinfo?taskID=3307866
> 
> The build fails for Rawhide. See the build.log:
> http://koji.fedoraproject.org/koji/getfile?taskID=3307867&name=build.log
> 
> aprspacket.cpp: In constructor 'AprsPacket::AprsPacket(const string&, const
> string&, const std::vector<std::basic_string<char> >&, const string&, const
> bool&)':
> aprspacket.cpp:131:55: error: too few arguments to function 'void
> fap_explain_error(fap_error_code_t, char*)'
> /usr/include/fap.h:381:6: note: declared here
> aprspacket.cpp: In copy constructor 'AprsPacket::AprsPacket(const AprsPacket&,
> const std::vector<std::basic_string<char> >&)':
> aprspacket.cpp:184:57: error: too few arguments to function 'void
> fap_explain_error(fap_error_code_t, char*)'
> /usr/include/fap.h:381:6: note: declared here
> aprspacket.cpp: In constructor 'AprsPacket::AprsPacket(fap_packet_t*, const
> bool&)':
> aprspacket.cpp:506:54: error: too few arguments to function 'void
> fap_explain_error(fap_error_code_t, char*)'
> /usr/include/fap.h:381:6: note: declared here
> 
> Don't know how to interpret this. The libfap-devel dependency is present in
> Rawhide (v.1.1.1).

Same errors in my attempts to build. For F14,15 and rawhide.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.