[Bug 188542] Review Request: hylafax

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=188542

--- Comment #117 from Miroslav Suchý <msuchy at redhat.com> 2011-10-24 15:36:06 EDT ---
hylafax.i686: W: no-manual-page-for-binary hylafax
hylafax.i686: W: no-manual-page-for-binary faxsetup.linux
hylafax.i686: W: no-manual-page-for-binary faxmsg
hylafax.i686: W: no-manual-page-for-binary ondelay
hylafax.i686: W: no-manual-page-for-binary probemodem
hylafax.i686: W: no-manual-page-for-binary lockname
hylafax.i686: W: no-manual-page-for-binary typetest
I encourage you to write man page for this executables.

hylafax.i686: W: wrong-file-end-of-line-encoding
/usr/share/doc/hylafax-5.5.0/COPYRIGHT
You have there probably DOS/WINDOWS style of end of line.

It is preferred to use %global rather then %define
http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define

Is there some reason to specify /usr/bin/tiffcp instead of libtiff-tools?

I'm going to talk to jskala (as he is the same building as me) about the
conflicts and virtual providess.

I second that change the name to hylafax+ is probably best thing.

I briefly read all this BZ (as it is very long) and still does not understand
(even after reading #92) why that stuff in /usr/spool/ is there? Can you
elaborate why it could not be moved to /etc /usr/bin /var/log etc? And I'm
sorry in advance, if you will repeat yourself and I missed it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.