[Bug 747050] Review Request: python-postman - cli for working with Amazon SES

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=747050

Richard Shaw <hobbes1069 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hobbes1069 at gmail.com

--- Comment #5 from Richard Shaw <hobbes1069 at gmail.com> 2011-10-26 11:01:46 EDT ---
A couple of other observations:

1. Python macros:

%if 0%{?fedora} > 12 || 0%{?rhel} > 6
# off by default until there is a python3-boto package
%global with_python3 0
%else
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print (get_python_lib())")}
%endif

Ok, it looks like you're kinda mixing the two examples from the Python
guidelines. I see you want to build for both versions 2 and 3, but because of
the lack of a necessary package in 3, you're disabling the version 3 module.

Unless the python3-boto package is going to be available in the near future,
wouldn't it be easier to not deal with all the v2 and v3 logic for now?

This would allow you to go back to the standard guideline logic...

%if ! (0%{?fedora} > 12 || 0%{?rhel} > 5)
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print(get_python_lib())")}
%endif


2. Since it looks like your building pure python modules you can drop CFLAGS in
%build.


3. it looks like you're using a common binary since %files inyour python3
package does not include a %{_bindir}. If that's the case then your python3
package should Requires: you python2 package. I'm not sure if this is legit,
but without it the python3 package will not have anything in /usr/bin.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.