[Bug 746754] Review request: PDFCrack - A Password Recovery Tool for PDF-files.

bugzilla at redhat.com bugzilla at redhat.com
Fri Oct 28 14:07:58 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=746754

--- Comment #14 from Ralf Corsepius <rc040203 at freenet.de> 2011-10-28 10:07:57 EDT ---
(In reply to comment #13)
> Is overriding a good idea?
In general, it's basically a matter of taste.

> I'm sure it's ok most of the time, but what if
> there's existing flags that are important to keep?
In general, you are right. One has to be careful about doing so (Properly
written Makefiles take this into consideration), but in this (trivial) case,
the CFLAGS inside of the Makefile can be neglected.

Actually this package is such kind of trivial and its Makefile lacking so much,
it could be compiled and build with a single compiler call without any
Makefile.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list