[Bug 663956] Review Request: python-numexpr - Fast numerical array expression evaluator for Python and NumPy.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=663956

Jussi Lehtola <jussi.lehtola at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |jussi.lehtola at iki.fi
               Flag|                            |fedora-review+

--- Comment #10 from Jussi Lehtola <jussi.lehtola at iki.fi> 2011-10-29 07:37:31 EDT ---
rpmlint output:
python-numexpr.src: W: spelling-error Summary(en_US) evaluator -> evaluate,
elevator
python-numexpr.src: W: spelling-error %description -l en_US runtime -> run
time, run-time, rudiment
python-numexpr.src: W: invalid-url Source0:
http://numexpr.googlecode.com/files/numexpr-1.4.2.tar.gz HTTP Error 404: Not
Found
python-numexpr.x86_64: W: spelling-error Summary(en_US) evaluator -> evaluate,
elevator
python-numexpr.x86_64: W: spelling-error %description -l en_US runtime -> run
time, run-time, rudiment
3 packages and 0 specfiles checked; 0 errors, 5 warnings.

These are OK (the URL does work).

**

About the chmod - files in %{python_sitelib} and %{python_sitearch} should have
644 permissions (755 for .so libraries), since they're normally not meant for
execution, but instead are imported by other programs.

**

Since there are benchmarks included, you must run it in the %check phase to
verify correct functionality, e.g.

%check
libdir=`ls build/|grep lib`
export PYTHONPATH=`pwd`/build/$libdir
python bench/timing.py

**

MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK

MUST: The spec file for the package is legible and macros are used
consistently. NEEDSWORK
- Please use %global instead of %define.
http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
OK
- LICENSE.txt defines a MIT license.
- License boilerplates are missing from the source code files. Please ask
upstream to add them.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
139115cc196dc57a66b2eb30cd3e80a0  numexpr-1.4.2.tar.gz
139115cc196dc57a66b2eb30cd3e80a0  ../SOURCES/numexpr-1.4.2.tar.gz

MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. N/A
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. N/A
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Debuginfo package is complete. OK

MUST: Permissions on files must be set properly. OK
- %defattr(-,root,root) is somewhat obsolete, usually %defattr(-,root,root,-)
is used.
- You can also drop this altogether along with the cleaning stuff and BuildRoot
tag, since they're defaulted in current versions of rpm.

MUST: Large documentation files must go in a -doc subpackage. N/A
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. N/A
MUST: Static libraries must be in a -static package. N/A
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. N/A
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned, architecture dependent dependency. N/A
MUST: Packages does not contain any .la libtool archives. N/A
MUST: Desktop files are installed properly. N/A
MUST: No file conflicts with other packages and no general names. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK
EPEL: Clean section exists. OK
EPEL: Buildroot cleaned before install. OK
EPEL: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. N/A

**

Add the check phase and switch the define to global before git import. This
package has been

APPROVED

Please also remember to ask upstream to add license boilerplates to the source
files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.