[Bug 711313] Review Request: wicd-kde - a Wicd client built on the KDE Development Platform

bugzilla at redhat.com bugzilla at redhat.com
Sat Oct 29 19:12:28 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=711313

--- Comment #23 from Gregor Tätzner <gregor at freenet.de> 2011-10-29 15:12:25 EDT ---
rpmlint wicd-kde-0.2.3-2.fc17.i686.rpm
       
================================================================================
        wicd-kde.i686: W: conffile-without-noreplace-flag
/etc/dbus-1/system.d/org.kde.wicdclient.scripts.conf
        wicd-kde.i686: W: no-manual-page-for-binary wicd-kde
        1 packages and 0 specfiles checked; 0 errors, 2 warnings.

-use %config(noreplace) (see packaging guideline).But to be honest: I'm not
exactly sure here, maybe the file should be replaced when a upgrade takes
place.

wicd-kde.src:73: W: macro-in-%changelog %make_install

-better don't put a %make_install in the changelog

-also the Buildroot tag seems to be wrong -  if you really want to make it epel
compatible:
http://fedoraproject.org/wiki/EPEL/GuidelinesAndPolicies#Distribution_specific_guidelines

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.


More information about the package-review mailing list