[Bug 719152] Review Request: gappalib-coq - Coq support library for gappa

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719152

--- Comment #4 from Jerry James <loganjerry at gmail.com> 2011-10-29 19:04:13 EDT ---
(In reply to comment #3)
> Unfortunatelly am not able to build you package:

Argh, I thought the ocaml-camlp5-devel BR would drag in ocaml, but it doesn't. 
I changed the spec file to explicitly BR ocaml.

> - The naming guidelines says "If a new package is considered an "addon" package
> that enhances or adds a new functionality to an existing Fedora package without
> being useful on its own, its name should reflect this fact.
> 
> The new package ("child") should prepend the "parent" package in its name, in
> the format: %{parent}-%{child}."
> 
> Therefor the package name should be "gaapa-coq". On the other hand it says
> "When naming a package, the name should match the upstream tarball or project
> name from which this software came." So gaapalib-coq would be correct to. I am
> fine with both of them. Just take a look at the two names and decide for
> yourself.

Heh.  Actually, the first version of this package was named gappa-coq.  After
awhile, though, I thought I should go with the upstream naming, and changed it
to its current name.  I think I would like to go with the current name.

> - Please use %{buildroot} instead of $RPM_BUILD_ROOT

Why?

> - You could create a marco for the coq version. So you dont have to maintain it
> on two places (Line 21 & 26 ).

Good idea.  I have made that change.  New URLs:

http://jjames.fedorapeople.org/gappalib-coq/gappalib-coq.spec
http://jjames.fedorapeople.org/gappalib-coq/gappalib-coq-0.16.0-3.fc17.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.