[Bug 604971] Review Request: jwm - Joe's Window Manager

Thu Sep 1 08:34:12 UTC 2011

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=604971

Mario Blättermann <mariobl at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+

--- Comment #28 from Mario Blättermann <mariobl at freenet.de> 2011-09-01 04:34:06 EDT ---
$ rpmlint -i -v *
jwm.i686: I: checking
jwm.i686: W: spelling-error %description -l en_US libXext -> extensible
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: W: spelling-error %description -l en_US libXmu -> Librium
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: W: spelling-error %description -l en_US libXinerama -> Cinerama
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: W: spelling-error %description -l en_US libXpm -> Librium
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: W: spelling-error %description -l en_US libjpeg -> libel
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: W: spelling-error %description -l en_US libpng -> sibling
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: W: spelling-error %description -l en_US libxft -> lift
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: W: spelling-error %description -l en_US antialiased -> anti aliased,
anti-aliased, initialized
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: W: spelling-error %description -l en_US libfribidi -> libidinal
The value of this tag appears to be misspelled. Please double-check.

jwm.i686: I: checking-url http://joewing.net/programs/jwm (timeout 10 seconds)
jwm.i686: E: incorrect-fsf-address /usr/share/doc/jwm-2.0.1/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jwm.src: I: checking
jwm.src: W: spelling-error %description -l en_US libXext -> extensible
The value of this tag appears to be misspelled. Please double-check.

jwm.src: W: spelling-error %description -l en_US libXmu -> Librium
The value of this tag appears to be misspelled. Please double-check.

jwm.src: W: spelling-error %description -l en_US libXinerama -> Cinerama
The value of this tag appears to be misspelled. Please double-check.

jwm.src: W: spelling-error %description -l en_US libXpm -> Librium
The value of this tag appears to be misspelled. Please double-check.

jwm.src: W: spelling-error %description -l en_US libjpeg -> libel
The value of this tag appears to be misspelled. Please double-check.

jwm.src: W: spelling-error %description -l en_US libpng -> sibling
The value of this tag appears to be misspelled. Please double-check.

jwm.src: W: spelling-error %description -l en_US libxft -> lift
The value of this tag appears to be misspelled. Please double-check.

jwm.src: W: spelling-error %description -l en_US antialiased -> anti aliased,
anti-aliased, initialized
The value of this tag appears to be misspelled. Please double-check.

jwm.src: W: spelling-error %description -l en_US libfribidi -> libidinal
The value of this tag appears to be misspelled. Please double-check.

jwm.src: I: checking-url http://joewing.net/programs/jwm (timeout 10 seconds)
jwm.src: I: checking-url
http://joewing.net/programs/jwm/snapshots/jwm-500.tar.bz2 (timeout 10 seconds)
jwm.x86_64: I: checking
jwm.x86_64: W: spelling-error %description -l en_US libXext -> extensible
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXmu -> Librium
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXinerama -> Cinerama
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libXpm -> Librium
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libjpeg -> libel
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libpng -> sibling
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libxft -> lift
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US antialiased -> anti
aliased, anti-aliased, initialized
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: W: spelling-error %description -l en_US libfribidi -> libidinal
The value of this tag appears to be misspelled. Please double-check.

jwm.x86_64: I: checking-url http://joewing.net/programs/jwm (timeout 10
seconds)
jwm.x86_64: E: incorrect-fsf-address /usr/share/doc/jwm-2.0.1/LICENSE
The Free Software Foundation address in this file seems to be outdated or
misspelled.  Ask upstream to update the address, or if this is a license file,
possibly the entire file with a new copy available from the FSF.

jwm-debuginfo.i686: I: checking
jwm-debuginfo.i686: I: checking-url http://joewing.net/programs/jwm (timeout 10
seconds)
jwm-debuginfo.x86_64: I: checking
jwm-debuginfo.x86_64: I: checking-url http://joewing.net/programs/jwm (timeout
10 seconds)
jwm.spec: I: checking-url
http://joewing.net/programs/jwm/snapshots/jwm-500.tar.bz2 (timeout 10 seconds)
5 packages and 1 specfiles checked; 2 errors, 27 warnings.

Spellchecker warnings could be ignored. For the incorrect FSF address, you
should ping the upstream developers, if that hasn't already been done.

---------------------------------
key:

[+] OK
[.] OK, not applicable
[X] needs work
---------------------------------

[+] MUST: The package must be named according to the Package Naming Guidelines.
[+] MUST: The spec file name must match the base package %{name}.
[+] MUST: The package must meet the Packaging Guidelines.
[+] MUST: The package must be licensed with a Fedora approved license.
    GPLv2+
[+] MUST: The License field in the package spec file must match the actual
license.
[+] MUST: The file containing the text of the license(s) for the package must
be included in %doc.
[+] MUST: The spec file must be written in American English.
[+] MUST: The spec file for the package MUST be legible.
[+] MUST: The sources used to build the package must match the upstream source.
    $ md5sum *
    e046d1720c8f9fcbffd58cb6c4b0dbad  jwm-500.tar.bz2
    e046d1720c8f9fcbffd58cb6c4b0dbad  jwm-500.tar.bz2.packaged

[+] MUST: The package MUST successfully compile and build into binary rpms on
at least one primary architecture.
    - Succesful Koji build available.
[.] MUST: If the package does not successfully compile, build or work on an
architecture, ...
[+] MUST: All build dependencies must be listed in BuildRequires.
[.] MUST: The spec file MUST handle locales properly.
[.] MUST: If a package installs files below %{_datadir}/icons, the icon cache
must be updated.
[.] MUST: Packages storing shared library files (not just symlinks) must call
ldconfig in %post and %postun.
[.] MUST: Packages must NOT bundle copies of system libraries.
[.] MUST: If the package is designed to be relocatable, ...
[+] MUST: A package must own all directories that it creates.
[+] MUST: A Fedora package must not list a file more than once in %files.
[+] MUST: Permissions on files must be set properly.
[+] MUST: Packages must not provide RPM dependency information when that
information is not global in nature, or are otherwise handled.
[.] MUST: When filtering automatically generated RPM dependency information,
the filtering system implemented by Fedora must be used.
[+] MUST: Each package must consistently use macros.
[+] MUST: The package must contain code, or permissable content.
[.] MUST: Large documentation files must go in a -doc subpackage.
[+] MUST: Files in %doc must not affect the runtime of the application.
[.] MUST: Header files must be in a -devel package.
[.] MUST: Static libraries must be in a -static package.
[.] MUST: If a package contains library files with a suffix (e.g.
libfoo.so.1.1), ...
[.] MUST: devel packages must require the base package using a fully versioned
dependency.
[.] MUST: Packages must NOT contain any .la libtool archives.
[.] MUST: Packages containing GUI applications must include a %{name}.desktop
file
[.] MUST: .desktop files must be properly installed with desktop-file-install
in the %install section.
[+] MUST: Packages must not own files or directories already owned by other
packages.
[+] MUST: All filenames in rpm packages must be valid UTF-8.

[.] SHOULD: If the source package does not include license text(s) as a
    separate file from upstream, the packager SHOULD query upstream...
[+] SHOULD: Timestamps of files should be preserved.
[+] SHOULD: The reviewer should test that the package builds in mock.
    See Koji build above (which uses mock anyway)
[+] SHOULD: The reviewer should test that the package functions as described.
    Works fine for me (f15, i686)
[.] SHOULD: If scriptlets are used, those scriptlets must be sane.
[.] SHOULD: Usually, subpackages other than devel should require the base
package using a fully versioned dependency.
[.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg.
[.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin ...
[+] SHOULD: Your package should contain man pages for binaries/scripts.

----------------

PACKAGE APPROVED

----------------

If you don't want to provide your package for EPEL < 6, then you might drop the
BuildRoot line, the %clean section, and %defattr.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.