[Bug 486570] Review Request: courier-authlib - The Courier authentication library provides authentication services for other Courier applications.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=486570

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |needinfo?(itamar at ispbrasil.
                   |                            |com.br)

--- Comment #21 from Rex Dieter <rdieter at math.unl.edu> 2011-09-02 10:41:24 EDT ---
$ rpmlint x86_64/*.rpm
courier-authlib.x86_64: W: conffile-without-noreplace-flag
/etc/authlib/authdaemonrc.dist
courier-authlib.x86_64: W: non-conffile-in-etc
/etc/ld.so.conf.d/courier-authlib.conf
courier-authlib.x86_64: W: non-standard-uid /var/spool/authdaemon courier
courier-authlib.x86_64: W: non-standard-gid /var/spool/authdaemon courier
courier-authlib.x86_64: W: no-manual-page-for-binary userdb-test-cram-md5
courier-authlib.x86_64: W: no-manual-page-for-binary pw2userdb
courier-authlib.x86_64: W: no-manual-page-for-binary authdaemond
courier-authlib.x86_64: W: no-manual-page-for-binary authenumerate
courier-authlib.x86_64: W: missing-lsb-keyword Default-Stop in
/etc/rc.d/init.d/courier-authlib
courier-authlib-debuginfo.x86_64: E: incorrect-fsf-address
/usr/src/debug/courier-authlib-0.63.0/authldaplib.c
courier-authlib-debuginfo.x86_64: W: hidden-file-or-dir
/usr/src/debug/courier-authlib-0.63.0/.libs
courier-authlib-debuginfo.x86_64: W: hidden-file-or-dir
/usr/src/debug/courier-authlib-0.63.0/.libs
courier-authlib-devel.x86_64: W: spelling-error %description -l en_US runtime
-> run time, run-time, runtish
courier-authlib-devel.x86_64: W: no-manual-page-for-binary courierauthconfig
courier-authlib-ldap.x86_64: W: conffile-without-noreplace-flag
/etc/authlib/authldaprc.dist
courier-authlib-mysql.x86_64: W: conffile-without-noreplace-flag
/etc/authlib/authmysqlrc.dist
courier-authlib-pgsql.x86_64: W: conffile-without-noreplace-flag
/etc/authlib/authpgsqlrc.dist
courier-authlib-pipe.x86_64: W: spelling-error %description -l en_US authpipe
-> auth pipe, auth-pipe, authorship
courier-authlib-pipe.x86_64: W: spelling-error %description -l en_US plugin ->
plug in, plug-in, plugging
courier-authlib-pipe.x86_64: W: spelling-error %description -l en_US stdin ->
stein, stain, stdio
courier-authlib-pipe.x86_64: W: spelling-error %description -l en_US stdout ->
stout, std out, std-out
courier-authlib-pipe.x86_64: W: no-documentation
courier-authlib-userdb.x86_64: W: no-documentation
8 packages and 0 specfiles checked; 1 errors, 22 warnings.

These are all mostly harmless.


naming: ok

sources: ok
411a927d178f783a1e8fab9964ce0dd2  courier-authlib-0.63.0.tar.bz2

macros: NOT OK, MUST fix.  See:
http://fedoraproject.org/wiki/Packaging/Guidelines#Macros
in particular,
"Macro forms of system executables SHOULD NOT be used except when there is a
need to allow the location of those executables to be configurable. For
example, rm should be used in preference to %{__rm}, but %{__python} is
acceptable."

init: SHOULD: update to include systemd unit file, instead of sysv init
http://fedoraproject.org/wiki/Packaging/Guidelines#Systemd

license: ok (though most sources only say "see COPYING", which is in general
not ideal, should explicitly mention license/copyright)

file/dir ownership: ok

SHOULD: investigate why shlibs are in %_libdir/courier-authlib instead of
%_libdir directly, so the ld.so.conf.d file could be removed


So, the only blocker I see so far, is the macro thing.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.