[Bug 652971] Review Request: code-editor - A text/code editor based on Qt Creator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652971

Rex Dieter <rdieter at math.unl.edu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |rdieter at math.unl.edu
               Flag|                            |fedora-review?,
                   |                            |needinfo?(ilyes.gouta at gmail
                   |                            |.com)

--- Comment #8 from Rex Dieter <rdieter at math.unl.edu> 2011-09-02 13:52:30 EDT ---
I can review.

naming: not sure.  Shouldn't code-editor version (roughly) match qt-creator? 
ie, your intention isn't to call it version 1 forever, is it? :)

sources: NOT ok, cannot verify sources
could you either provide release tarballs, or some script/recipe to generate
reproducible sources based on upstream tag or something?

license: ok

scriptlets: ok

macros: ok

SHOULD: simplify %files, what you have could be simplified using dirs and
globs, to something like:
%files
%{_bindir}/code-editor
%{_libdir}/code-editor/
%{_datadir}/code-editor/
%{_datadir}/icons/hicolor/*/*/codeeditor.*
%{_datadir}/applications/code-editor.desktop

SHOULD: .desktop file improvements,
add Comment= tag (for non-kde DE's, ie, gnome)
add more Categories, like Qt and maybe IDE (like qt-creator has), see also
http://standards.freedesktop.org/menu-spec/menu-spec-latest.html#category-registry

SHOULD: replace
BuildRequires: qt-devel
Requires: qt
with
BuildRequires: qt4-devel
%{?_qt4_version:Requires: qt4%{?_isa} >= %{_qt4_version}}
(the latter will ensure that a dependency on at least version of qt that was
used to build it with).
(for fun, see /etc/rpm/macros.qt4 for other qt-related rpm macros)

SHOULD: I see a lot of items removed at end of %install section, please
document what these are and why they're omitted from packaging.

So, the only real blocker here that I'd like at least some clarification is the
upstream version/sources thing.  The rest are all nice-to-have's.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.