[Bug 652971] Review Request: code-editor - A text/code editor based on Qt Creator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=652971

--- Comment #11 from Ilyes Gouta <ilyes.gouta at gmail.com> 2011-09-03 08:53:42 EDT ---
Hi Rex,

> naming: not sure.  Shouldn't code-editor version (roughly) match qt-creator?
> ie, your intention isn't to call it version 1 forever, is it? :)

I updated the .spec file to indeed reflect qt-creator's actual version. Yes,
I'm always rebasing on Qt Creator's stable branches, so using the same version
makes sense.

> sources: NOT ok, cannot verify sources
> could you either provide release tarballs, or some script/recipe to
> generate reproducible sources based on upstream tag or something?

I just finished uploading a .tar.bz2 snapshot at
http://ilyes.fedorapeople.org/code-editor-src.tar.bz2

The same code base can be obtained from the git repository, by issuing a:

$ git clone git://gitorious.org/~ilyesgouta/qt-creator/code-editor.git -b
code-editor_2.3

> SHOULD: simplify %files, what you have could be simplified using dirs
> and globs, to something like:

I corrected and simplified the .spec file and uploaded it on fedorapeople.org.
It's available at: http://ilyes.fedorapeople.org/code-editor.spec

I've also regenerated the SRPM and uploaded it there.

-Ilyes

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.