[Bug 732215] Review Request: mined - Powerful Text Editor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=732215

Michael Schwendt <mschwendt at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|177841(FE-NEEDSPONSOR)      |

--- Comment #3 from Michael Schwendt <mschwendt at gmail.com> 2011-09-03 14:51:53 EDT ---
* Removing FE-NEEDSPONSOR as I see you've been sponsored already.


* Licensing issue: This is ambiguous and therefore not acceptable. Sublicensing
(or restricting the GPL further) also violates the GPL itself. It would be
better if upstream simply acknowledge the GPL licensing without trying to add
extra licensing terms. You might want to point upstream at: 

http://www.gnu.org/philosophy/free-sw.html
http://www.gnu.org/licenses/gpl-faq.html


> rm -rf %{buildroot}%{_datadir}/mined/help/mined.hlp          \
>       %{buildroot}%{_datadir}/mined/setup_install/win       \
>       %{buildroot}%{_datadir}/mined/setup_install/bin       \
>       %{buildroot}%{_datadir}/mined/setup_install/mined.ico \
>       %{buildroot}%{_datadir}/mined/bin                     \
>       %{buildroot}%{_datadir}/mined/package_doc

Great opportunity to add a brief comment to the spec file explaining why this
is done. What files are these? Why are they not needed? Often, deleting files
is dubious activity that bears a risk of breaking the package, e.g. due to
missing files at run-time.


> %{_datadir}/mined/conf_user/*
> %{_datadir}/mined/doc_user/*

Three directories are not included here:
https://fedoraproject.org/wiki/Packaging:UnownedDirectories


> gcc -DTERMIO -Dunix -DsysV -Dunix -ansi -Waggregate-return -Winline
> -Wimplicit-int -Wunused -Wswitch -Wchar-subscripts -Wparentheses
> -Wmissing-braces  -Wno-pointer-sign -O2  -Wmissing-prototypes
> -Wreturn-type -DRUNDIR=\"/usr/share/mined\"
> -DLRUNDIR=\"/usr/local/share/mined\" -c mined1.c

Fedora's optflags are not used.
The /usr/local/… path is suspicous.


* Notice .desktop file warnings in build output.


* Run rpmlint also on all built rpms, not just the src.rpm. There are some real
errors reported there. If in doubt, use rpmlint -i.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.