[Bug 735705] Review Request: xs - Shell supporting functional programming

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=735705

Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+

--- Comment #2 from Parag AN(पराग) <panemade at gmail.com> 2011-09-05 01:38:45 EDT ---
Review:

+ source verified as 
9fcf9ca4f95802b8022e680155a37d195aa6578e  ../SOURCES/frytvm-XS-9c19777.tar.gz
9fcf9ca4f95802b8022e680155a37d195aa6578e   frytvm-XS-9c19777.tar.gz

+ rpmlint gave output as 
xs.src: E: description-line-too-long C It is based off the source-code for the
es project, which was in the public domain.
xs.src: E: description-line-too-long C since es-0.9-beta1 are all parts of xs
and have been written by Frederic Koehler.
==> Fix this before import

+ Packaging looks ok.

Suggestions:
1) following can preserve timestamp of man page
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

2) COPYING should be included as %doc

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.