[Bug 733603] Review Request: sugar-ruler - Ruler is a simple collection of measurement tools that are displayed on the screen.

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=733603

Peter Robinson <pbrobinson at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dwmw2 at infradead.org
          Component|Package Review              |0xFFFF

--- Comment #12 from Peter Robinson <pbrobinson at gmail.com> 2011-09-06 18:33:46 EDT ---
It mostly looks OK. There's a few minor issues to be fixed with the spec file.
The issue that needs to be fixed is the install of the locales, we'll likely
need to speak to upstream to fix this. The rest of the warnings in rpmlint are
fine.

- rpmlint output

rpmlint sugar-ruler.spec sugar-ruler-11-5.fc15.src.rpm
sugar-ruler-11-5.fc15.noarch.rpm

sugar-ruler.spec:6: W: non-standard-group Sugar/Activities
sugar-ruler.spec:47: W: macro-in-%changelog %{__python}
sugar-ruler.spec:55: W: macro-in-%changelog %clean
sugar-ruler.spec:57: W: macro-in-%changelog %{buildroot}
sugar-ruler.src: W: non-standard-group Sugar/Activities
sugar-ruler.src:47: W: macro-in-%changelog %{__python}
sugar-ruler.src:55: W: macro-in-%changelog %clean
sugar-ruler.src:57: W: macro-in-%changelog %{buildroot}
sugar-ruler.noarch: W: non-standard-group Sugar/Activities
sugar-ruler.noarch: E: invalid-lc-messages-dir
/usr/share/locale/cpp/LC_MESSAGES/com.laptop.Ruler.mo
sugar-ruler.noarch: E: invalid-lc-messages-dir
/usr/share/locale/nah/LC_MESSAGES/com.laptop.Ruler.mo
sugar-ruler.noarch: E: incorrect-locale-subdir
/usr/share/locale/templates/LC_MESSAGES/com.laptop.Ruler.mo
sugar-ruler.noarch: E: invalid-lc-messages-dir
/usr/share/locale/templates/LC_MESSAGES/com.laptop.Ruler.mo
sugar-ruler.noarch: E: invalid-lc-messages-dir
/usr/share/locale/ton/LC_MESSAGES/com.laptop.Ruler.mo
2 packages and 1 specfiles checked; 5 errors, 9 warnings.

+ package name satisfies the packaging naming guidelines
+ specfile name matches the package base name
+ package should satisfy packaging guidelines
+ license meets guidelines and is acceptable to Fedora
+ license matches the actual package license
+ latest version packaged

+ %doc includes license file
+ spec file written in American English
+ spec file is legible
+ upstream sources match sources in the srpm
  e43770148f189a80e0d91907ad834f97  Ruler-11.tar.bz2
+ package successfully builds on at least one architecture
  tested using koji scratch build
+ BuildRequires list all build dependencies
+ %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun+ does not use Prefix: /usr
n/a package owns all directories it creates
n/a no duplicate files in %files
+ Package perserves timestamps on install
+ Permissions on files must be set properly 
+ %defattr line
- consistent use of macros
  Need to use %{__python} in install
+ package must contain code or permissible content
n/a large documentation files should go in -doc subpackage
+ files marked %doc should not affect package runtime 
n/a header files should be in -devel
n/a static libraries should be in -static
n/a packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a devel must require the fully versioned base
+ packages should not contain libtool .la files
n/a packages containing GUI apps must include %{name}.desktop file
+ packages must not own files or directories owned by other packages
+ filenames must be valid UTF-8

Optional:

+ if there is no license file, packager should query upstream to include it
n/a translations of description and summary for non-English languages, if
available
+ reviewer should build the package in mock/koji
n/a the package should build into binary RPMs on all supported architectures
n/a review should test the package functions as described
n/a scriptlets should be sane
n/a non -devel packages should require fully versioned base
n/a pkgconfig files should go in -devel
+ shouldn't have file dependencies outside /etc /bin /sbin /usr/bin or
/usr/sbin
n/a Package should have man files

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.