[Bug 674544] Review Request: rubygem-searchlogic - ruby library making ActiveRecord named scopes easier

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=674544

Bohuslav Kabrda <bkabrda at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |bkabrda at redhat.com

--- Comment #1 from Bohuslav Kabrda <bkabrda at redhat.com> 2011-09-07 08:14:19 EDT ---
Unofficial review:
* Should have Requires: ruby; BuildRequires: ruby
* Use BuildRequires: ruby(rubygems) instead of just rubygems.
* Use %prep section (useful when applying patches later) and %build section
(rpmlint complains about that).
* Consider excluding .gitignore files in %files section with %exclude rather
than removing them in %install.
* You don't need to use %defattr in %files, since it is a default (see
https://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions).
* Instead of listing %{gemdir}/gems/%{gemname}-%{version}/ in %files, you can
just list %{geminstdir} (macro that you defined).
* Also, you should rather use %dir %{geminstdir}, which will make rpmbuild stop
warning about files listed twice.
* Consider adding a doc subpackage for the documentation (see
https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Subpackages).
* Use %check section to run spec tests (see
hhttps://fedoraproject.org/wiki/Packaging_talk:Ruby#RSpec). For this, you will
also need BuildRequires: rubygem(rspec).
* Did you test with Rails 3?
* Koji task link: https://koji.fedoraproject.org/koji/taskinfo?taskID=3332223

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.