[Bug 735518] Review Request: html-unit-core-js - a Rhino fork for HtmlUnit

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=735518

hannes <johannes.lips at googlemail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |johannes.lips at googlemail.co
                   |                            |m

--- Comment #1 from hannes <johannes.lips at googlemail.com> 2011-09-07 12:56:46 EDT ---
Some quick comments on that package, which should be fixed before I start the
formal review.

- the javadoc subpackage should require the package
Requires:       %{name} = %{version}-%{release}

- remove bundled jar files with something like:
find -name '*.class' -exec rm -f '{}' \;
find -name '*.jar' -exec rm -f '{}' \;
find -name '*.zip' -exec rm -f '{}' \;

- fix the license tag (already talked about it in IRC)

I don't think that besides those things there isn't much left.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.