[Bug 736069] Review Request: apache-parent

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736069

Stanislav Ochotnicky <sochotni at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|                            |fedora-review+

--- Comment #1 from Stanislav Ochotnicky <sochotni at redhat.com> 2011-09-08 08:59:49 EDT ---
I'll do the shortened version because the spec is really small and clean.
Licensing is OK (ASL 2.0) rpmlint is completely clean. Basically everything is
A-OK. I just have 2 suggestions:

1. You can put the url directly into Source0. It would be a problem if there
were more pom.xml files, but that's not the case so...
2. It's usually better to be specific i.e. have %{_mavendepmapfragdir}/%{name}
instead of * (same for the pom line)

These two non-issues are really small and basically up to you if you want to
handle them. Package is APPROVED. I'll remove common-poms apache-parent once
this package is in...

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.