[Bug 735944] Review Request: comex-base - base component for comex project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=735944

--- Comment #2 from Mamoru Tasaka <mtasaka at fedoraproject.org> 2011-09-08 16:00:03 EDT ---
Well, only did a very quick check

* License tag
  - GPLv2 is chosen for license tag in your spec, however
    I cannot see any files which specifies the version of
    GPL in the source. Note that just including GPLv2 license
    text does not actually specify the version of GPL
    used in the source.

    Currently License tag should be "GPL+"

* BuildRequires
  - Currently your srpm won't build on koji. Please make it
    sure that your srpm builds on koji (or with mockbuild)
    http://koji.fedoraproject.org/koji/taskinfo?taskID=3336036

    It seems mono-devel is needed for BR

* Explicit dependency
  - Note that with adding "BR: mono-devel", rpmbuild will find
    out mono-related runtime dependency (i.e. Requires)
    automatically and adds the detected dependencies to binary
    rpms. So writing "Requires: mono-core log4net" explicitly
    is not needed (after adding BR: mono-devel)

* Requires for main pacakge
  - Usually Requires for main package on subpackages should
    be (Epoch:)Version-Release specific and also isa specific

    https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package

* pkgconfig dependency
  - Explicit "Requires: pkgconfig" is no longer needed on Fedora,
    it is added automatically by rpmbuild
    https://fedoraproject.org/wiki/Packaging/Guidelines#Pkgconfig_Files

* Deprecated usage
  Please remove lines which are no longer needed
  - %if 0%{?fedora} < 13 condition is useless. Fedora's version is at
    least 14 currently
  - The following is no longer needed on Fedora (EPEL may still need
    these)
    * BuildRoot: line
    * rm -fr %{buildroot} at the top of %install
    * %clean section

* Directory ownership issue
  - The directory %{_libdir}/mono/gac/ itself is owned by mono-core and
    this package should not own this directory itself.
  - The directory %{_datadir}/%{name}/ is not owned by any packages and
    this package should own it

* Requires: pcsc-lite-devel
  - Can't this be avoided by patching comex-base/comex-base.dll.config?

Note that I will be away till Sunday so it may be that replying to you
becomes late. By the way I will appreciate it if you would review my
review request (bug 678674)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.