[Bug 736994] Review request: rubygem-bson_ext - C extensions for Ruby BSON

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736994

--- Comment #2 from Vít Ondruch <vondruch at redhat.com> 2011-09-09 08:08:59 EDT ---
* Descriptive filenames
  - It would be fine if the Source1 and Source2 files could have more
descriptive
    names, such as %{gemname}-%{version}-tests-upstream.tgz and 
    %{gemname}-%{version}-tests-patch.tgz

* Make sure that the test suite is really using the C extension
  - There is recorded following notice in buildlog, which makes me wonder if
the
    test suite is really doing what is supposed to do:

    "Notice: C extension not loaded. This is required for optimum MongoDB Ruby
     driver performance."

* pushd should be paired with popd
  - It is considered good habit I would say

* Test cleanup
  - The test suite is extracted in temporary directory, but it is not later
    removed.

* Files not required for runtime should be moved into -doc subpackage
  - Please move "%{geminstdir}/Rakefile" and "%{geminstdir}/bson_ext.gemspec" 
    into -doc subpackage according to [1]

[1] http://fedoraproject.org/wiki/Packaging:Guidelines#Documentation

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.