[Bug 736163] Review Request: gobi_loader - Firmware loader for Qualcomm Gobi WWAN devices

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736163

Felix Kaechele <felix at fetzig.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |felix at fetzig.org

--- Comment #2 from Felix Kaechele <felix at fetzig.org> 2011-09-10 08:18:41 EDT ---
Hi there.

Here are my comments on your package:

1. SRPM spec file differs from standalone spec file (File in SRPM misses the
disttag)
2. BuildRoot, %clean and rm -rf $RPM_BUILD_ROOT (in %install) can be removed
(unless you want to get this package into EPEL too)
3. The upstream makefile ignores the $RPM_OPT_FLAGS. It should be patched to
correctly set the compiler flags.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.