[Bug 736163] Review Request: gobi_loader - Firmware loader for Qualcomm Gobi WWAN devices

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 12 00:25:19 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736163

--- Comment #4 from Bojan Smojver <bojan at rexursive.com> 2011-09-11 20:25:19 EDT ---
(In reply to comment #2)
> 1. SRPM spec file differs from standalone spec file (File in SRPM misses the
> disttag)

Corrected. Must have copied an older copy of the spec file out by accident.

> 2. BuildRoot, %clean and rm -rf $RPM_BUILD_ROOT (in %install) can be removed
> (unless you want to get this package into EPEL too)

It doesn't hurt and we may do an EPEL package, so I'll let it stay for now.

> 3. The upstream makefile ignores the $RPM_OPT_FLAGS. It should be patched to
> correctly set the compiler flags.

Should be fixed here:

ftp://ftp.rexursive.com/pub/gobi_loader/gobi_loader.spec
ftp://ftp.rexursive.com/pub/gobi_loader/gobi_loader-0.7-3.fc15.src.rpm

Once again, thank you for your contribution.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list