[Bug 719103] Review Request: mex - Media centre application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=719103

--- Comment #3 from Bastien Nocera <bnocera at redhat.com> 2011-09-12 06:36:46 EDT ---
(In reply to comment #2)
> rpmlint mex-0.1.4-1.fc17.x86_64.rpm 
> mex.x86_64: W: spelling-error Summary(en_US) centre -> center, cent re, cent-re
> mex.x86_64: W: spelling-error %description -l en_US centre -> center, cent re,
> cent-re

Fixed.

> mex.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/mex/plugins/40mex-recommended.so ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/mex/plugins/100mex-debug.so ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/mex/plugins/20mex-gnome-dvb.so ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/mex/plugins/40mex-queue.so ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/mex/plugins/00mex-search.so ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/mex/plugins/20mex-tracker.so ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/mex/plugins/20mex-upnp.so ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mex-webremote
> ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath /usr/bin/mex ['/usr/lib64']
> mex.x86_64: E: binary-or-shlib-defines-rpath
> /usr/lib64/mex/plugins/50mex-dbusinput.so ['/usr/lib64']
> mex.x86_64: E: incorrect-fsf-address /usr/share/doc/mex-0.1.4/COPYING
> mex.x86_64: E: postun-without-ldconfig /usr/lib64/libmex-0.2.so.0.0.0
> mex.x86_64: W: devel-file-in-non-devel-package /usr/lib64/libmex-0.2.so
> mex.x86_64: W: no-manual-page-for-binary mex-webremote
> mex.x86_64: W: no-manual-page-for-binary mex-debug
> mex.x86_64: W: no-manual-page-for-binary mex
> 
> Get rid of the rpaths. See
> http://fedoraproject.org/wiki/Packaging:Guidelines#Removing_Rpath

Fixed.

> Please contact the developer, so he can update the license file with the one up
> to date. You may opt to correct the address in the package.

https://github.com/media-explorer/media-explorer/issues/140

> Libs in standard directories need an ldconfig run. See
> http://fedoraproject.org/wiki/Packaging:Guidelines#Shared_Libraries

Yep.

> You'll need a devel sub-package:
> http://fedoraproject.org/wiki/Packaging:Guidelines#Devel_Packages

Nope. The files are only there for introspection purposes. There is no support
for 3rd-party plugins.

> Installing files to /usr/share/icons, you need this scriptlet:
> http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache

Done.

> Use the name macro instead of "mex".

Done where it made sense.

> Try to break the %configure line.

Done.

> You can drop the defattr line. It's not necessary.

Done.

> If you don't plan to go for EPEL5 or older, drop the clean section and the rm
> in the install section. If you want to go for EPEL5, define the buildroot.

Done.

> Be more specific in your file section. For instance: all binaries start with
> %{name}.

Done.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.