[Bug 730324] Review Request: telepathy-kde-accounts-kcm-plugins - Plugins for protocol-specific UI's in the Telepathy Accounts KCM

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730324

Radek Novacek <rnovacek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |rnovacek at redhat.com
         AssignedTo|nobody at fedoraproject.org    |rnovacek at redhat.com
               Flag|                            |fedora-review?

--- Comment #1 from Radek Novacek <rnovacek at redhat.com> 2011-09-12 08:22:34 EDT ---
Name: ok
License: wrong, spec says GPLv2+, source is LGPLv2+
Source: wrong URL, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/%{name}_%{version}.tar.bz2
BRs/Reqs: BuildRequires: desktop-file-utils present but no desktop-file-* used
Macros used consistently: ok
ldconfig: not needed
Desktop file validations: not needed
Docs: commented out, why?
Devel: NA
Files: ok
Build: ok
rpmlint: 
telepathy-kde-accounts-kcm-plugins.src:4: W: mixed-use-of-spaces-and-tabs
(spaces: line 2, tab: line 4)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.