[Bug 736717] Review Request: lcmaps - Grid (X.509) and VOMS credentials to local account mapping

bugzilla at redhat.com bugzilla at redhat.com
Mon Sep 12 22:52:14 UTC 2011


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=736717

Al Reay <alreay1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alreay1 at gmail.com

--- Comment #1 from Al Reay <alreay1 at gmail.com> 2011-09-12 18:52:14 EDT ---
Hi Dennis,
I'm not authorized to sponsor you but I'll happily help review your SRPM.

* rpmlint on your .spec file reports:
lcmaps.spec:241: W: macro-in-%changelog %post

maybe change that comment to read "-added ldconfig to 'postun' section

* The spec file you've linked is different to that included in the SRPM. In the
linked spec file you've got a 'release' variable that is based off the current
date (with resolution down to the minute). This means that you get a
differently versioned package basically everytime you rebuild it. I'm pretty
sure this is not going to be acceptable to the Fedora packagers. I think that
packages are routinely rebuilt (for different architectures, releases etc) and
that this will just cause a constant stream of updates to be applied to clients
using the software even when no changes have occurred.

Apologies if I've misunderstood something here.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.



More information about the package-review mailing list