[Bug 730331] Review Request:telepathy-kde-send-file - A File manager plugin to launch a file transfer job with a specified contact

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=730331

Radek Novacek <rnovacek at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |rnovacek at redhat.com
         AssignedTo|nobody at fedoraproject.org    |rnovacek at redhat.com
               Flag|                            |fedora-review?

--- Comment #1 from Radek Novacek <rnovacek at redhat.com> 2011-09-13 03:58:59 EDT ---
Name: ok
License: wrong, spec says GPLv2+, source is LGPLv2+
Source: wrong URL, should be
http://download.kde.org/unstable/telepathy-kde/%{version}/src/telepathy-kde-send-file_%{version}.tar.bz2
instead of
http://download.kde.org/unstable/unstable/telepathy-kde/%{version}/src/telepathy-kde-send-file_%{version}.tar.bz2
BRs/Reqs: BuildRequires: desktop-file-utils present but no desktop-file-* used
Macros used consistently: ok
ldconfig: not needed
Desktop file validations: not needed
Docs: ok
Devel: NA
Files: ok
Build: ok
rpmlint:
telepathy-kde-send-file.src:4: W: mixed-use-of-spaces-and-tabs (spaces: line 2,
tab: line 4)
telepathy-kde-send-file.x86_64: W: no-manual-page-for-binary
telepathy-kde-send-file
telepathy-kde-send-file.x86_64: E: invalid-desktopfile
/usr/share/applications/kde4/telepathy-kde-send-file.desktop (will be fatal in
the future): value "all/allfiles;" for key "MimeType" in group "Desktop Entry"
contains value "all/allfiles" which is an invalid MIME type: "all" is an
unregistered media type
telepathy-kde-send-file.x86_64: E: invalid-desktopfile
/usr/share/applications/kde4/telepathy-kde-send-file.desktop required key
"Name" in group "Desktop Entry" is not present
telepathy-kde-send-file.x86_64: E: invalid-desktopfile
/usr/share/applications/kde4/telepathy-kde-send-file.desktop key "MimeType" is
present in group "Desktop Entry", but the type is "Service" while this key is
only valid for type "Application"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.