[Bug 739088] Review Request: arandr - Simple GTK+ XRandR GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739088

Gregor Tätzner <gregor at freenet.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gregor at freenet.de

--- Comment #2 from Gregor Tätzner <gregor at freenet.de> 2011-09-16 14:27:35 EDT ---
Hi Maros,
some additional feedback:

rpmlint RPMS/noarch/arandr-0.1.4-1.fc15.noarch.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
ok

rpmlint SRPMS/arandr-0.1.4-1.fc15.src.rpm 
arandr.src:14: W: mixed-use-of-spaces-and-tabs (spaces: line 14, tab: line 2)
1 packages and 0 specfiles checked; 0 errors, 1 warnings.

In the spec file you are mixing tabs and spaces. Don't do this. It's better to
use spaces only.

the %doc entry is incomplete. You must add at least the license and readme,
changelog, news and todo too, I think.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.