[Bug 738554] Review Request: perl-Test-HexString - Test binary strings with hex dump diagnostics

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=738554

Remi Collet <fedora at famillecollet.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at famillecollet.com
         AssignedTo|nobody at fedoraproject.org    |fedora at famillecollet.com
               Flag|                            |fedora-review?

--- Comment #1 from Remi Collet <fedora at famillecollet.com> 2011-09-17 02:42:01 EDT ---
=== FORMAL REVIEW ===
 -=N/A  x=Check  !=Problem,  ?=Not evaluated

=== REQUIRED ITEMS ===
 [x] Rpmlint output:
perl-Test-HexString.noarch: E: incorrect-fsf-address
/usr/share/doc/perl-Test-HexString-0.02/LICENSE
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [x] Package meets the Packaging Guidelines including the Perl specific items
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPL+ or Artistic
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file, containing the text of the license(s) for the
package is included in %doc.
 [x] Spec file is legible and written in American English.
 [x] Sources used to build the package matches the upstream source, as provided
in the spec URL.
 md5sum : 9ad36ed82057320048c0777b69e737b6  Test-HexString-0.02.tar.gz
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: f15 x86_64
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that
are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Packages don't bundle copies of system librarie
 [x] Package is not relocatable.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [-] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [-] Header files in -devel subpackage, if present.
 [-] Static libraries in -static subpackage, if present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages with %{?_isa}, if present.
 [x] Package does not contain any libtool archives (.la).
 [-] Package contains a properly installed %{name}.desktop file if it is a GUI
 [x] All filenames in rpm packages must be valid UTF-8
 [x] Package does not own files or directories owned by other packages.
 Own /usr/share/perl5/vendor_perl/Test already own
 but subject to perl exception.

=== SUGGESTED ITEMS ===
 [x] Final requires
perl(:MODULE_COMPAT_5.12.4)  
perl(Test::Builder)  
 [x] Final provides
perl(Test::HexString) = 0.02
perl-Test-HexString = 0.02-1.fc15
 [!] Latest version is packaged.
 [-] If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it. 
 [?] The description and summary sections in the package spec file should
contain
     translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: Koji 
 http://koji.fedoraproject.org/koji/taskinfo?taskID=3357052
 [-] The package should compile and build into binary rpms on all supported
architectures.
     Tested on: N/A for noarch
 [?] Package functions as described.
 [x] If scriptlets are used, those scriptlets must be sane. 
 [-] If the package has file dependencies outside of /etc, /bin, /sbin,
/usr/bin, or /usr/sbin 
     consider requiring the package which provides the file instead of the file
itself. 
 [x] your package should contain man pages for binaries/scripts. 
     If it doesn't, work with upstream to add them where they make sense.
 [-] The placement of pkgconfig(.pc) files is correct.
 [x] %check is present and the tests pass

Should
- package latest version 0.03, released yesterday... ;)
  fix fixes the fsf address bug
- make %file more exclicite (I personally hate to wide joker)


No blocker,
Do you want me to approve 0.02 or do you prefer to update the spec ?
(I prefer to have the latest version in the repo)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.