[Bug 739088] Review Request: arandr - Simple GTK+ XRandR GUI

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739088

--- Comment #5 from Veeti Paananen <veeti.paananen at rojekti.fi> 2011-09-17 16:18:49 EDT ---
You're mixing macro and variable styles for getting the build root
(%{buildroot} and $RPM_BUILD_ROOT), which is against the guidelines [1]. Pick
one and use it consistently. (IMO, the macro style is superior since macros are
also used for other things like the directory paths. It's also shorter.)

[1]
http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.