[Bug 735152] Review Request: step - Interactive Physics Simulator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=735152

Clément DAVID <c.david86 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |c.david86 at gmail.com
         AssignedTo|nobody at fedoraproject.org    |c.david86 at gmail.com
               Flag|                            |fedora-review?

--- Comment #1 from Clément DAVID <c.david86 at gmail.com> 2011-09-18 10:01:14 EDT ---
For me some points to be solved before a more formal review:
 * typo on "Release: 10%{?dist}" for a first try :)
 * is it standard to use desktop-file-validate on %check ? (I use it on %build)

koji build : http://koji.fedoraproject.org/koji/taskinfo?taskID=3358761

Problems:

+ desktop-file-validate
/builddir/build/BUILDROOT/step-4.7.0-10.fc16.i386/usr/share/applications/kde4/step.desktop
/builddir/build/BUILDROOT/step-4.7.0-10.fc16.i386/usr/share/applications/kde4/step.desktop:
error: (will be fatal in the future): value "Physics" in key "Categories" in
group "Desktop Entry" requires another category to be present among the
following categories: Education;Science

warning: File listed twice: /usr/share/doc/HTML/en/step

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.