[Bug 739323] Review Request: mozilla-https-everywhere - HTTPS/HSTS enforcement extension for Mozilla browsers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=739323

Al Reay <alreay1 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |alreay1 at gmail.com

--- Comment #2 from Al Reay <alreay1 at gmail.com> 2011-09-18 19:40:01 EDT ---
Hi Russell, I'm not a proven packager so I can't sponsor or approve your
package but I'll cheerfully do an informal review for you.

* just a niggle, the srpm link isn't fully formed with respect to the https
certificate, to avoid wget/curl download errors make sure that it's got a 'www'
prefix to match the servername as per the cert.

* I think your use of explicit 'requires' tag is OK here because automatic
dependency resolution by RPM won't work as you're using it only to see if a
directory structure exists (as opposed to using a library or binary)

Nice simple package, I think you'll have no problems getting this one through.

Good luck
Al

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.