[Bug 737308] Review Request: gdlmm - C++ bindings for the gdl library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=737308

Kalev Lember <kalevlember at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #2 from Kalev Lember <kalevlember at gmail.com> 2011-09-19 03:36:47 EDT ---
Thanks for the review, Dodji!

(In reply to comment #1)
> The only warning I'd care about are the unused-direct-shlib-dependency
> one.  I believe this is because the gdlmm upstream tarball lacks
> -Wl,-as-needed linker option.  This is not an error.  It'll merely
> cause a slower-to-load library.  My recommendation would be to report
> this upstream, but I wouldn't block this package because of that.

I'm not really sure this is something that each individual GNOME module
should have to handle. Perhaps the flag should come from distro-wide LDFLAGS
instead. I know Mandriva has been doing this for a while:
http://wiki.mandriva.com/en/Overlinking#--as-needed

Some Fedora packages have amazing hacks to get -Wl,-as-needed passed to
the linker, for example gtk3 is doing this by patching the libtool script
with sed:
http://pkgs.fedoraproject.org/gitweb/?p=gtk3.git;a=blob;f=gtk3.spec;h=835a21a64ce1bf2d59baeaf5e1e58ada4f50a20d;hb=HEAD#l130

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.